Bug Fixes for Joomla Cloner 1.6 | Old Forum | Forum Archive

Hi,

I've been playing with JoomlaCloner 1.6 and I found the following issues on your
"Generate Backup" page. I hope I don't bother you too much. Despite these bugs,
Joomla Cloner is a GREAT GREAT tool! 🙂

Cheers!

I. FIXED

You will find the files modified by my fixes in the attached ZIP archive.

I.1 MAJOR ISSUE

Web browser (if settings set accordingly.) raises a Javascript error in file
xmlhttp.js when calling function useXML(request.responseXML) in function
processXMLRequest().

This is due to the fact that accessing $_REQUEST[] and $_CONFIG[] with bad index
names (i.e. missing surrounding quotes) generates warning messages that are fatal
to your xml request/response business streaming.

Examples:

<br /><b>Notice</b>: Undefined index: path in<b>
.../administrator/components/com_cloner/browser/files_xml.php</b>
on line <b>23</b><br />
<br /><b>Notice</b>: Undefined index: dir in<b>
.../administrator/components/com_cloner/browser/files_xml.php</b>
on line <b>24</b><br />
<br /><b>Notice</b>: Undefined index: act in<b>
.../administrator/components/com_cloner/browser/files_xml.php</b>
on line <b>28</b><br />
<br /><b>Notice</b>: Undefined index: act in<b>
.../administrator/components/com_cloner/browser/files_xml.php</b>
on line <b>33</b><br />

This is true even with "Error Reporting" option (Joomla global configuration)
set to "Simple".

I also made your useXML() Javascript function more robust when request.responseXML
is empty.

I.2 MINOR ISSUE

Default checking for the following local configuration options:

- "Backup database and include in this backup set"
- "Add DROP SYNTAX"
- "Backup Name"

should take into account the following global configuration options (from the
"Cron" tab):

- "Backup type" ("Full (files + database)" / "Files only" / "Database only")
- "Add Mysql Drop"
- "Please choose your backup name"

II TO BE FIXED

II.1 MAJOR ISSUE

When setting "Backup type" global configuration option to "Database only",
the web site folders should NOT be included in the backup archive.

II.2 MINOR ISSUES

- Related to the previous major issue:
The tabs in the "Generate Backup" page should be visible according to the
"Backup type" global configuration option: "Database Options" tab only for
"Full (files + database)" or "Database only" option values and "Structure"
and "Files Options" tabs only for "Full (files + database)" or "Files only"
option values.

- A bunch of language-dependent strings are still hardcoded in your php files.
They'd better be externalized in english.php, so the day I decide to translate
JoomlaCloner in french, everything will be easy and clean as a wistle! 😉

III OPENED ISSUES

III.1 SAFE MODE

Your component needs to have "Safe_Mode" PHP directive set to Off to work properly.
BUT do you think that if this option is set to "On", it would be possible (on a
Linux server only) to set the "safe_mode_exec_dir" directive with the path of a
directory containing symbolic links to tar, zip and mysqldump programs? Would it
work?

Post edited by: eelziere, at: 2006/09/09 05:49